allow list for expressions #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and improving test coverage
…onsistency and clarity; add `github.owner` to AllowedExpressions
…d remove unused expressions
dsyme
reviewed
Aug 13, 2025
dsyme
reviewed
Aug 13, 2025
dsyme
reviewed
Aug 13, 2025
dsyme
reviewed
Aug 13, 2025
…nsolidating GitHub Actions expressions.
… adjust tests for accuracy
…ity validation in workflow markdown
Contributor
Author
|
@dsyme i think it's ready. sorry busy with other things |
dsyme
reviewed
Aug 14, 2025
dsyme
reviewed
Aug 14, 2025
dsyme
reviewed
Aug 14, 2025
Contributor
Author
|
do you want to take over? Busy for a next few hours. |
…r clarity and completeness
pelikhan
added a commit
that referenced
this pull request
Sep 4, 2025
* Make missing-tool safe output optional instead of always enabled by default (#53) * Initial plan * Implement missing-tool safe output for reporting unavailable functionality Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Make missing-tool safe output optional instead of always enabled Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Optimize frontmatter error location detection with sub-YAML search for nested additional properties (#50) * Remove GITHUB_TOKEN usage from format-and-commit workflow * Initial plan * Improve frontmatter error source location logic for additional properties and offsets Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Enhance nested additional properties error location handling - Modified LocateJSONPathInYAMLWithAdditionalProperties to handle additional properties in nested objects - Added findAdditionalPropertyInNestedContext function to locate properties within specific JSON path contexts - Added findNestedSection function to identify YAML sections corresponding to JSON paths - Added comprehensive test coverage for nested additional properties scenarios - Maintains backward compatibility with existing root-level additional properties handling Fixes handling of errors like "at '/on': additional properties 'foobar' not allowed" to point to exact location of 'foobar' rather than the 'on:' line. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Optimize nested additional properties search for JSON paths When a JSON path is available, search within sub-YAML content instead of entire YAML: - Extract the YAML content for the specific JSON path section - Normalize indentation for the sub-content - Perform additional property search within the extracted sub-YAML - Map coordinates back to original YAML positions This improves efficiency by avoiding searches through unrelated YAML sections and provides more precise error location detection as requested in feedback. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add support for custom environment variables in engine configuration using GitHub Actions syntax (#56) * Initial plan * Add support for custom environment variables in engine configuration Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Change env field type from array to map for GitHub Actions compatibility Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com> * Add missing tool reporting functionality to workflow and update documentation * Add missing tool reporting functionality to workflow and update documentation --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refuse markdown that uses unsafe expression inserts.